fix: skip dependencies on openshift platform #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benedikt Bongartz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1921 +/- ##
=======================================
Coverage 88.25% 88.26%
=======================================
Files 100 100
Lines 6303 6307 +4
=======================================
+ Hits 5563 5567 +4
Misses 543 543
Partials 197 197
Continue to review full report at Codecov.
|
rubenvp8510
reviewed
May 31, 2022
| @@ -213,6 +213,13 @@ func EsScriptEnvVars(opts v1.Options) []corev1.EnvVar { | |||
| envs = append(envs, corev1.EnvVar{Name: x.envVar, Value: val}) | |||
| } | |||
| } | |||
|
|
|||
| if val, ok := options["skip-dependencies"]; ok { | |||
There was a problem hiding this comment.
Why do we need to add the environment var if the option is specified?
There was a problem hiding this comment.
For cronjobs, only selected parameters are passed as environment variables. Here we pass user settings if they exist. If no user settings are present and the operator runs on openshift, we set skip-dependencies=true.
Details: #1896 (comment)
rubenvp8510
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benedikt Bongartz [email protected]
Which problem is this PR solving?
Short description of the changes
cc @rubenvp8510